Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting as CI step #38

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Add linting as CI step #38

merged 3 commits into from
Sep 7, 2022

Conversation

thomshutt
Copy link
Contributor

@thomshutt thomshutt commented Sep 7, 2022

Let's try and lint from the start of this project

@thomshutt thomshutt changed the base branch from main to split-http-handlers September 7, 2022 12:39
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #38 (e7139c3) into main (14b71d8) will decrease coverage by 1.76833%.
The diff coverage is 3.22581%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main         #38         +/-   ##
===================================================
- Coverage   44.42675%   42.65842%   -1.76833%     
===================================================
  Files             12          12                 
  Lines            628         647         +19     
===================================================
- Hits             279         276          -3     
- Misses           312         332         +20     
- Partials          37          39          +2     
Impacted Files Coverage Δ
api/http.go 57.14286% <0.00000%> (ø)
handlers/ok.go 40.00000% <0.00000%> (-60.00000%) ⬇️
handlers/triggers.go 0.00000% <0.00000%> (ø)
handlers/upload.go 44.92754% <0.00000%> (-2.83365%) ⬇️
middleware/logging.go 0.00000% <0.00000%> (ø)
handlers/transcode.go 44.44444% <100.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b71d8...e7139c3. Read the comment docs.

Impacted Files Coverage Δ
api/http.go 57.14286% <0.00000%> (ø)
handlers/ok.go 40.00000% <0.00000%> (-60.00000%) ⬇️
handlers/triggers.go 0.00000% <0.00000%> (ø)
handlers/upload.go 44.92754% <0.00000%> (-2.83365%) ⬇️
middleware/logging.go 0.00000% <0.00000%> (ø)
handlers/transcode.go 44.44444% <100.00000%> (ø)

Base automatically changed from split-http-handlers to main September 7, 2022 22:07
@emranemran emranemran merged commit 1c3a78e into main Sep 7, 2022
@emranemran emranemran deleted the split-http-handlers-lint branch September 7, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants